Repository navigation
tests: mem_trim accepts the BC3 scratch's even-size argument - #799
Closed
madebyjordan wants to merge 1 commit into
Closed
madebyjordan wants to merge 1 commit into
madebyjordan wants to merge 1 commit into
Conversation
NotRexed#705 made the two BC3 uploads call bc_scratch_layout(cmd, resized) so an upload encoded at an even size also gets the second scratch. test_mem_trim looked for the exact text bc_scratch_layout(cmd), found 0 of 2 and failed, turning "Game-free source regressions" red on main since f2223df. It now matches the call with or without that argument and still fails when either upload stops asking for the scratch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Confirmed independently: the unchanged current base reproduces the BC3 assertion failure. This patch passes with both the prior one-argument calls and the current resize-argument calls. Removing either current upload or copy guard makes it fail again. The same base issue is the only source-test failure in #793; its new shader-stamp check passes on Windows and Linux. CPU source checks only; no GPU behavior claim. |
This was referenced Nov 8, 2026
This was referenced Nov 8, 2026
Owner
|
Thank you for the fix! #806 made the same repair to tests/test_mem_trim.py (it checks each upload's resize argument separately) and has now been merged, so main's test passes. Closing this one as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#705 broke
tests/test_mem_trim.py, sorry about that. Its merge with #585 made both BC3 uploads callbc_scratch_layout(cmd, resized)so an upload encoded at an even size also gets the second scratch. The test looks for the exact textif (!bc_scratch_layout(cmd)) return false;twice, finds none, and "Game-free source regressions" has been red on main since f2223df (it was green at 58af2c0). #705's own CI never ran because the fork workflow approval expired.The check now matches the call with or without the second argument. It still fails if either upload stops asking for the scratch (checked by removing one guard: the count drops to 1).
Tested:
python -I -B tests/run_all.pyon 232eecb + this change.test_mem_trimpasses. The only other local failures are Windows-environment ones (symlink privilege intest_nup_paths, clang/<initializer_list>intest_fps_overlay_order).🤖 Generated with Claude Code